Merged
Conversation
sreichl
reviewed
Mar 22, 2026
sreichl
reviewed
Mar 22, 2026
sreichl
reviewed
Mar 22, 2026
sreichl
reviewed
Mar 22, 2026
sreichl
reviewed
Mar 22, 2026
sreichl
requested changes
Mar 22, 2026
Collaborator
sreichl
left a comment
There was a problem hiding this comment.
Please address the comments and also run a test if it works (once with correct and once with not correctly filled config/annotation).
Collaborator
Author
|
incorporated feedback, tested, and still works |
sreichl
requested changes
Mar 22, 2026
Collaborator
Author
|
really nice finding, I moved them and it still works 🎉 Thanks! |
Collaborator
|
ready to merge? |
Collaborator
Author
|
yes |
Collaborator
|
@hoferand similarly to the formatting and linting, can you provide clear instructions and resources for setting up the validation scheme, including also but not limited to potential AI prompts that worked well? Thanks. |
Collaborator
Author
|
Sure!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.