Check full SEED ID when comparing picks and waveforms#481
Open
calum-chamberlain wants to merge 19 commits intodevelopfrom
Open
Check full SEED ID when comparing picks and waveforms#481calum-chamberlain wants to merge 19 commits intodevelopfrom
calum-chamberlain wants to merge 19 commits intodevelopfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clean take-over from #391
Uses full SEED information (adds network and location) when comparing e.g. pick.waveform_id and tr.stats in a number of functions. Mostly importantly template_gen, but may also include mag_calc and others.
Why was it initiated? Any relevant Issues?
#388
In situations where the desired template or trace contains unique picks with the same Station and Channel, but different location and/or Network codes (e.g. separate sensors in one borehole), current behavior does not differentiate between them.
Assorted to-dos:
utils.correlatefuncs all returncccs,no_chans, andchans.chansonly includes station.channel, which then gets passed toDetectionobjects. Allow for full seed chans inDetectionchansattribute forDetectionobjects...could touch quite a lot...UsedChannelonly uses station.channel. Allow for full seed option.Pickobjects and link from depreciation warning.PR Checklist
developbase branch selected?CHANGES.md.CONTRIBUTORS.md.