Skip to content

ENH: Use gridname as name for simulator_fipregions_mapping#1634

Draft
tnatt wants to merge 1 commit intoequinor:mainfrom
tnatt:change-fipnum-mapping-name
Draft

ENH: Use gridname as name for simulator_fipregions_mapping#1634
tnatt wants to merge 1 commit intoequinor:mainfrom
tnatt:change-fipnum-mapping-name

Conversation

@tnatt
Copy link
Copy Markdown
Collaborator

@tnatt tnatt commented Mar 18, 2026

Resolves #1633

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@tnatt tnatt force-pushed the change-fipnum-mapping-name branch from 1e49211 to 5e58cd3 Compare March 18, 2026 12:12
@tnatt tnatt marked this pull request as ready for review March 18, 2026 12:15
@tnatt tnatt force-pushed the change-fipnum-mapping-name branch from 5e58cd3 to fce4160 Compare March 18, 2026 12:16
@tnatt tnatt self-assigned this Mar 18, 2026
@tnatt tnatt requested a review from HansKallekleiv March 18, 2026 16:11
Copy link
Copy Markdown
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast :)
From a consumer perspective I guess this is more or less on hold until the relevant mapping from modelling grid to simulation grid is in place?

@tnatt
Copy link
Copy Markdown
Collaborator Author

tnatt commented Mar 26, 2026

Will put this on hold until we have specked out how to do the mapping of a rms grid name to a eclipse grid name. Most likely fmu settings can be of use here.

@tnatt tnatt marked this pull request as draft March 26, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support fipnum mappings from multiple grids

2 participants