feat(kona/service): refactor kona-service to make it easier to test the derivation pipeline#19141
Open
feat(kona/service): refactor kona-service to make it easier to test the derivation pipeline#19141
Conversation
Contributor
Plan expiredYour subscription has expired. Please renew your subscription to continue using CI/CD integration and other features. |
f07d99d to
57c0037
Compare
theochap
commented
Feb 10, 2026
theochap
commented
Feb 10, 2026
theochap
commented
Feb 10, 2026
57c0037 to
3c158a1
Compare
theochap
commented
Feb 11, 2026
theochap
commented
Feb 11, 2026
theochap
commented
Feb 11, 2026
theochap
commented
Feb 11, 2026
theochap
commented
Feb 11, 2026
bab5bf2 to
3ea4493
Compare
c1fe1d3 to
d0dc567
Compare
Comment on lines
+24
to
38
| let build_ticker = tokio::time::interval(Duration::from_secs(rollup_config.block_time)); | ||
| SequencerActor { | ||
| admin_api_rx, | ||
| attributes_builder: TestAttributesBuilder { attributes: vec![] }, | ||
| cancellation_token: CancellationToken::new(), | ||
| conductor: None, | ||
| engine_client: MockSequencerEngineClient::new(), | ||
| is_active: true, | ||
| in_recovery_mode: false, | ||
| origin_selector: MockOriginSelector::new(), | ||
| rollup_config: Arc::new(RollupConfig::default()), | ||
| rollup_config, | ||
| unsafe_payload_gossip_client: MockUnsafePayloadGossipClient::new(), | ||
| build_ticker, | ||
| next_payload_to_seal: None, | ||
| last_seal_duration: Duration::from_secs(0), | ||
| } |
Contributor
There was a problem hiding this comment.
Missing initialization of the needs_reset field in the test actor construction. The SequencerActor struct now includes a needs_reset: bool field (added in actor.rs line 138), but it's not being initialized here. This will cause a compilation error.
SequencerActor {
// ... existing fields ...
build_ticker,
next_payload_to_seal: None,
last_seal_duration: Duration::from_secs(0),
needs_reset: false, // Add this line
}Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
88089e6 to
d3f9b7f
Compare
90b2651 to
e2d8b4c
Compare
…he derivation pipeline fix(kona/service): fix rust-fmt and rust-docs CI failures Fix trailing `|` formatting in match arm and resolve broken `CancellationToken` intra-doc link. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e2d8b4c to
07272e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeActortrait and all actor implementations inkona-serviceto simplify initialization and improve testability of the derivation pipelineInboundDatapattern to decouple actor construction from inter-actor communication wiringTest plan
cargo nextest run --package kona-node-service)🤖 Generated with Claude Code