Skip to content

feat(op-chain-ops): use supernode for check-super-root for check super root tests#19454

Open
stevennevins wants to merge 7 commits intodevelopfrom
stevennevins/supernode-rpc-verify
Open

feat(op-chain-ops): use supernode for check-super-root for check super root tests#19454
stevennevins wants to merge 7 commits intodevelopfrom
stevennevins/supernode-rpc-verify

Conversation

@stevennevins
Copy link
Contributor

@stevennevins stevennevins commented Mar 9, 2026

Summary

  • switch check-super-root action test coverage from using op-supervisor to using supernode

Testing

  • go test ./op-e2e/actions/interop -run TestSuperRootScript -count=1
  • go build ./op-chain-ops/cmd/check-super-root

Metadata

Fixes #19177

@stevennevins stevennevins marked this pull request as ready for review March 9, 2026 20:30
@stevennevins stevennevins requested a review from a team as a code owner March 9, 2026 20:30
@ajsutton
Copy link
Contributor

Ah I think there's some confusion here - we want to keep the check-super-root script accepting multiple EL endpoints. That way you can use providers like Alchemy who won't provide supernode endpoints. I suspect we just need to switch the test over from using supervisor to verify against to supernode.

@stevennevins
Copy link
Contributor Author

Ah I think there's some confusion here - we want to keep the check-super-root script accepting multiple EL endpoints. That way you can use providers like Alchemy who won't provide supernode endpoints. I suspect we just need to switch the test over from using supervisor to verify against to supernode.

Makes sense, will adjust

@stevennevins stevennevins changed the title feat(op-chain-ops): use supernode rpc for check-super-root feat(op-chain-ops): use supernode for check-super-root for check super root tests Mar 12, 2026
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the one nit.

timestamp uint64,
check func(*assert.CollectT, eth.SuperRootAtTimestampResponse),
) eth.SuperRootAtTimestampResponse {
t.Helper()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd remove this. there are multiple places this method could cause the test to fail so we'd want to get the actual line, but t.Helper() will entirely exclude it from the stack trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-chain-ops: update check super root script to be checked against supernode

2 participants