feat(op-chain-ops): use supernode for check-super-root for check super root tests#19454
feat(op-chain-ops): use supernode for check-super-root for check super root tests#19454stevennevins wants to merge 7 commits intodevelopfrom
Conversation
|
Ah I think there's some confusion here - we want to keep the check-super-root script accepting multiple EL endpoints. That way you can use providers like Alchemy who won't provide supernode endpoints. I suspect we just need to switch the test over from using supervisor to verify against to supernode. |
Makes sense, will adjust |
ajsutton
left a comment
There was a problem hiding this comment.
LGTM. Just the one nit.
| timestamp uint64, | ||
| check func(*assert.CollectT, eth.SuperRootAtTimestampResponse), | ||
| ) eth.SuperRootAtTimestampResponse { | ||
| t.Helper() |
There was a problem hiding this comment.
nit: I'd remove this. there are multiple places this method could cause the test to fail so we'd want to get the actual line, but t.Helper() will entirely exclude it from the stack trace.
Summary
check-super-rootaction test coverage from using op-supervisor to using supernodeTesting
Metadata
Fixes #19177