feat(rust): karst-derive inlined derivation pipeline#19487
Draft
feat(rust): karst-derive inlined derivation pipeline#19487
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #19487 +/- ##
===========================================
+ Coverage 75.3% 75.8% +0.4%
===========================================
Files 194 623 +429
Lines 11285 67630 +56345
===========================================
+ Hits 8502 51269 +42767
- Misses 2639 16361 +13722
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kona-karst-derive, a flat, inlined OP Stack derivation pipeline that replaces the stagedkona-derivearchitecturePipelinestruct holds all intermediate state as fields; all derivation steps are direct method calls (no trait-based stage composition)kona-derivefor compatibilityKey simplifications vs kona-derive
ChannelProvidermux (bank vs assembler)BatchProvidermux (queue vs validator)BatchStream.is_active()guardFrameQueueconditional Holocene pruningMAX_RLP_BYTES_PER_CHANNEL100_000_000)reset()methodTest plan
cargo check -p kona-karst-derivecompilescargo clippy -p kona-karst-derivepasses with zero warnings🤖 Generated with Claude Code