Skip to content

fix: clear pending tx when cancelled #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
acha-bill wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clear pending tx when cancelled #5138

acha-bill wants to merge 1 commit into from
+36 −14

Conversation

@acha-bill
Copy link
Contributor

@acha-bill acha-bill commented Jul 1, 2025

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Remove pending tx from store when it is cancelled

Related Issue (Optional)

closes #5123
closes #5129

Screenshots (if appropriate):

@acha-bill acha-bill requested review from gacevicljubisa and janos July 1, 2025 13:09
@nikipapadatou nikipapadatou added the ready for review The PR is ready to be reviewed label Jul 10, 2025
nugaon
nugaon approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinconic martinconic martinconic approved these changes

@nugaon nugaon nugaon approved these changes

@sbackend123 sbackend123 sbackend123 approved these changes

@gacevicljubisa gacevicljubisa Awaiting requested review from gacevicljubisa

@janos janos Awaiting requested review from janos

Assignees

@acha-bill acha-bill

Labels

ready for review The PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cancelled transaction still returned from /transactions endpoint Stuck pending transaction - logs indicate cancellation, but it seems successful

6 participants

@acha-bill @martinconic @nugaon @sbackend123 @nikipapadatou