Magnum Renderer#3
Draft
mosra wants to merge 53 commits intoeundersander:eundersander/batched_kinematic_simfrom
Draft
Magnum Renderer#3mosra wants to merge 53 commits intoeundersander:eundersander/batched_kinematic_simfrom
mosra wants to merge 53 commits intoeundersander:eundersander/batched_kinematic_simfrom
Conversation
mosra
force-pushed
the
magnum-renderer
branch
2 times, most recently
from
4693edb to
9475d1e
Compare
Author
|
Current state of the code should compile with bundled magnum (updated the submodules and Basis dependency to the versions/branches that are needed). Right now only the |
* switch episode JSON rotations from Mat3x3 to Quat * force zero action for first step of episode (on the assumption that the action was computed from a stale observation) * more robust error-handling for episode JSON loading
… stepMin/stepMax * add collection.json startJointPositions * add resetting to BatchedSimTest
…esearch#1719) Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
…nt_positions_normalized
…tTest; improve PlacementHelper::place; support for procedural robot placement
…nd support for random joint start positions
All on master except for magnum which currently uses the scenedata-optimizations branch.
This is a difference to Habitat master, which omits the Zstd files. But otherwise the KTX files won't load.
Nothing works. Everything broken.
Hopefully it now does what it should do, except that I'm still unsure WHY it would do that.
Causes one extra empty draw to be submitted for each added object, which isn't exactly fast, but at least it's correct. Not great, not terrible.
…ges. Ahh finally found the core reason for all textures being Y-flipped for SOME REASON. Gotta fix that in glTF exporter, if I'd have proper tests from the start i would have discovered that weeks ago. Also a "proof" that it works in the demo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[outdated info removed, will add back later]