fix(exec): expose lefthook binary on PATH for nested hook commands - #1519
Open
rwinkelman wants to merge 2 commits into
Open
fix(exec): expose lefthook binary on PATH for nested hook commands#1519rwinkelman wants to merge 2 commits into
rwinkelman wants to merge 2 commits into
Conversation
Git push hooks often run with a stripped PATH, so jobs like `run: lefthook validate` fail even though the parent lefthook process is running. Prepend the running binary's directory to PATH and set LEFTHOOK_BIN for child commands. Fixes evilmartians#1518
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "fix(exec): warn when lefthook PATH enric..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Log executable/symlink resolution failures instead of silently skipping PATH enrichment, and refactor env tests to the table-driven convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-push), the environment often has a strippedPATHrun: lefthook validatethen fail withsh: lefthook: command not foundeven though the parent process is lefthookPATHand setLEFTHOOK_BINfor every job commandFixes #1518
Test plan
withLefthookEnv(env_test.go)go test ./internal/run/controller/exec/...