Fix macOS build bundling wrong macmon binary#1797
Merged
Conversation
…sion The build was using `brew install macmon` which installs the upstream vladkens/macmon that doesn't support M5 Pro/Max. Now uses the same swiftraccoon/macmon fork pinned in flake.nix via `nix develop`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Tested on a new macOS build. Works on both M5 Pro and M4 Max. |
Evanev7
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #1747 fixed macmon support for M5 Pro/Max by pinning the
swiftraccoon/macmonfork inflake.nix. This works when running from source (via Nix) but the distributed macOS.appbuild was still broken on M5 Pro/Max because it was bundling the wrong macmon.The error on M5 Pro/Max:
Changes
macmonfrombrew installinbuild-app.yml— this was installing the upstreamvladkens/macmonwhich doesn't support M5 Pro/Maxswiftraccoon/macmonat rev9154d23already defined inflake.nix) and adds it to$GITHUB_PATHbrew uninstall macmonto ensure no Homebrew macmon can shadow the pinned versionWhy It Works
PyInstaller bundles macmon via
shutil.which("macmon"). Previously this found the Homebrew (upstream) binary. Now it finds the Nix-overlayed fork that has M5 Pro/Max support, because$GITHUB_PATHprepends the Nix store path before the PyInstaller step runs.Test Plan
Manual Testing
.appon M5 Pro/Max and confirm macmon preflight succeedsAutomated Testing