docs: simplify code examples with header comments#386
Merged
UlisesGascon merged 2 commits intoexpressjs:masterfrom Jan 13, 2026
Merged
docs: simplify code examples with header comments#386UlisesGascon merged 2 commits intoexpressjs:masterfrom
UlisesGascon merged 2 commits intoexpressjs:masterfrom
Conversation
- Add comments showing which CORS headers get set - Simplify response bodies to 'Hello' - Simplify console.log messages
jonchurch
force-pushed
the
docs/add-headers-to-examples
branch
from
d8a90ce to
1d4a759
Compare
4 tasks
UlisesGascon
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an attempt to reduce confusion in the docs #384
The docs should absolutely show what headers are being added, as that is the whole point of this library
idk yet if I want the response messages to refer to what "will happen" in the browser. Split between the examples being mechanical (what does this library actually add/do) vs functional (what is the effect in the browser). So for now just simplified the response messages