Also copy woof.pk3 next to the executable when building for Mac#2636
Merged
rfomin merged 1 commit intofabiangreffrath:masterfrom Mar 14, 2026
Merged
Also copy woof.pk3 next to the executable when building for Mac#2636rfomin merged 1 commit intofabiangreffrath:masterfrom
rfomin merged 1 commit intofabiangreffrath:masterfrom
Conversation
Collaborator
|
Thank you! |
Owner
|
Hm, even on Linux the $ LANG=C ls -l build/src
total 6772
drwxrwxr-x 4 fabian fabian 4096 Mar 14 20:05 CMakeFiles
-rw-rw-r-- 1 fabian fabian 3032 Mar 14 20:05 cmake_install.cmake
-rwxrwxr-x 1 fabian fabian 5990184 Mar 14 20:06 woof
-rwxrwxr-x 1 fabian fabian 623136 Mar 14 20:06 woof-setup
-rw-rw-r-- 1 fabian fabian 303385 Mar 14 20:06 woof.pk3 |
Owner
|
Seriously, I don't get it. In the top-level set(BASE_PK3_PATH "${CMAKE_BINARY_DIR}/src/${BASE_PK3}")And in add_custom_command(OUTPUT "${BASE_PK3_PATH}"
COMMAND ${CMAKE_COMMAND} -E tar cf "${BASE_PK3_PATH}" --format=zip ${BASE_SOURCES}
DEPENDS ${BASE_SOURCES}
WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}")So, the |
Collaborator
I think it's an issue with the Mac Xcode IDE. Windows Visual Studio also has a special directory structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when trying to play Woof built from source, I get a "woof.pk3 not found" error, which unfortunately can't be solved by changing the working directory or providing command-line parameters, but I have to actively copy or symlink the file post-build. I've noticed that the build system only does the copying for Windows (and only with Visual Studio), so I'm suggesting to also do it on Mac. Since currently there's no elaborate app bundle target (for which I would most likely try to put it in the "../share" path inside the bundle), just a raw executable, I think it's fine for now to just copy the woof.pk3 next to woof, for convenience.