Skip to content

Replace curses.ascii.iscntrl #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seproDev wants to merge 1 commit into from
Closed

Replace curses.ascii.iscntrl #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fontbro/font.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import tempfile
from collections import Counter
from collections.abc import Generator
from curses import ascii
from io import BytesIO
from pathlib import Path
from typing import IO, Any, cast
Expand Down Expand Up @@ -36,6 +35,7 @@
from fontbro.utils import (
concat_names,
find_item,
is_control_character,
read_json,
remove_spaces,
slugify,
Expand Down Expand Up @@ -509,7 +509,7 @@ def get_characters(
char = chr(code)
else:
continue
if ascii.iscntrl(char):
if is_control_character(char):
continue
if glyfs and ignore_blank:
glyf = glyfs.get(char_name)
Expand Down
6 changes: 6 additions & 0 deletions fontbro/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,9 @@ def slugify(
s = re.sub(r"[^\w\-]", "", s)
s = s.strip("-")
return s.lower().strip().replace(" ", "-")


def is_control_character(
char: str,
) -> bool:
return ord(char) < 0x20 or ord(char) == 0x7F