Skip to content

Actually run tests on multiple platforms#237

Merged
fabiocaccamo merged 2 commits intofabiocaccamo:mainfrom
seproDev:run-tests
Jan 8, 2026
Merged

Actually run tests on multiple platforms#237
fabiocaccamo merged 2 commits intofabiocaccamo:mainfrom
seproDev:run-tests

Conversation

@seproDev
Copy link
Copy Markdown
Contributor

@seproDev seproDev commented Jan 7, 2026


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
The tests were always running under Ubuntu. See https://github.com/fabiocaccamo/python-fontbro/actions/runs/20791181188/job/59713461231?pr=236#step:1:10

Related issue
?

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.27%. Comparing base (4a2b086) to head (6cc0878).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files           8        8           
  Lines         971      971           
=======================================
  Hits          964      964           
  Misses          7        7           
Flag Coverage Δ
unittests 99.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seproDev
Copy link
Copy Markdown
Contributor Author

seproDev commented Jan 7, 2026

Ugh, pwsh does not fail on a non-zero exit codes. So even though the tests fail the pipeline is green https://github.com/fabiocaccamo/python-fontbro/actions/runs/20791991364/job/59716109363?pr=237#step:7:30
Changing to use bash.

@seproDev
Copy link
Copy Markdown
Contributor Author

seproDev commented Jan 7, 2026

Okay, great the tests fail on Windows now. I can rebase once #236 and #238 are merged.

@fabiocaccamo fabiocaccamo moved this to Todo in Open Source Jan 8, 2026
@fabiocaccamo fabiocaccamo added the bug Something isn't working label Jan 8, 2026
@fabiocaccamo
Copy link
Copy Markdown
Owner

@seproDev great catch!! Thank you very much.

@fabiocaccamo fabiocaccamo merged commit 39de833 into fabiocaccamo:main Jan 8, 2026
15 of 20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Open Source Jan 8, 2026
@seproDev seproDev deleted the run-tests branch January 8, 2026 21:50
@seproDev
Copy link
Copy Markdown
Contributor Author

seproDev commented Jan 8, 2026

The shell: bash is required so that the tests actually fail 6f5929e#diff-eac64e6701be029f3c62c0f7bfd0f4e5516758675f07c8eb5bd12af6054b1394L49

So right now on main the tests run, but the pipeline step doesn't fail even though the tests fail. Alternatively, $ErrorActionPreference = "Stop" could be used, but that would then require separate run steps for Windows and macOS/Linux.

@seproDev seproDev mentioned this pull request Jan 8, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants