Skip to content

Add support for MemorySwappiness - #1547

Open
maxant wants to merge 4 commits into
fabric8io:masterfrom
maxant:feature/1546
Open

Add support for MemorySwappiness#1547
maxant wants to merge 4 commits into
fabric8io:masterfrom
maxant:feature/1546

Conversation

@maxant

@maxant maxant commented Apr 26, 2022

Copy link
Copy Markdown

Fix #1546

@rohanKanojia

Copy link
Copy Markdown
Member

@maxant : Thanks for the PR, Could you please address test failures?

@maxant

maxant commented May 20, 2022

Copy link
Copy Markdown
Author

@rohanKanojia sorry for the wait :-)

Can I add a couple other properties into this PR or should I create a new issue? It would be more of the same for Init and MemoryReservation

@maxant

maxant commented May 20, 2022

Copy link
Copy Markdown
Author

@rohanKanojia on the e2e tests I get this error:

https://app.circleci.com/pipelines/github/fabric8io/docker-maven-plugin/447/workflows/c5ab7a02-823e-4278-b401-dd8513241f29/jobs/4232?invite=true#step-103-1342

ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.2:war (default-war) on project dockerfile: 
Execution default-war of goal org.apache.maven.plugins:maven-war-plugin:2.2:war failed: Unable to load the mojo 'war' in the
 plugin 'org.apache.maven.plugins:maven-war-plugin:2.2' due to an API incompatibility:
 org.codehaus.plexus.component.repository.exception.ComponentLookupException: Cannot access defaults field of Properties

I don't really understand the error message - do you have any tips?

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia

Copy link
Copy Markdown
Member

Umm, not sure about e2e failures. Could you please try rebasing your branch and see if it gets resolved?

@rohanKanojia

Copy link
Copy Markdown
Member

@maxant: polite ping, are you still working on this?

@maxant

maxant commented Jun 26, 2022

Copy link
Copy Markdown
Author

@maxant: polite ping, are you still working on this?

yes but with very low priority, unfortunately

@rhuss rhuss changed the title 1546 suggested feature Add support for MemorySwappiness Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for MemorySwappiness when creating containers please

2 participants