-
Notifications
You must be signed in to change notification settings - Fork 25k
[RN][HermesV1] Use Hermes V1 as default engine #54989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D89881943. |
Job Summary for GradleTest All :: build_android
|
5064dfa to
350a654
Compare
|
I’m pretty new to React Native and this change for iOS looks great. Could you help me understand if Android will use Hermes V1 by default too? |
|
@complexapps2026 the goal is also for Android to do that. this PR only contains changes related to iOS. A similar PR for Android will be opened soon! |
4faf893 to
d88d553
Compare
d88d553 to
b42ebc6
Compare
b42ebc6 to
874f569
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: build_android
|
eb1669e to
e99a190
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: build_android
|
e99a190 to
9eddb95
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: build_android
|
9eddb95 to
fcdd1a0
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
1 similar comment
Job Summary for GradleTest All :: run_fantom_tests
|
cortinico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
|
This pull request was successfully merged by @cipolleschi in f140c49 When will my fix make it into a release? | How to file a pick request? |
Summary:
This change makes Hermes V1 the default engine for React Native for both platforms. This change needs to land before the branch cut of react native 0.84
Changelog:
[iOS][Changed] - Make Hermes V1 the default engine for iOS
Test Plan:
bundle exec pod installand verified that Hermes V1 is used when building from source