optionally calculate originFromRoot for ShadowNode and pass to ShadowView#55045
Open
zeyap wants to merge 1 commit intofacebook:mainfrom
Open
optionally calculate originFromRoot for ShadowNode and pass to ShadowView#55045zeyap wants to merge 1 commit intofacebook:mainfrom
zeyap wants to merge 1 commit intofacebook:mainfrom
Conversation
…View Summary: ## Changelog: [General] [Added] - optionally calculate originFromRoot for ShadowNode and pass to ShadowView * If a LayoutableShadowNode calls `layout()` with `LayoutContext.includeOriginFromRoot==true`, all its (recursive) children will calculate `originFromRoot`. This will be needed for shared transition/view transition, where we'll later need to know the absolute position of a shadowNode/shadowView * if includeOriginFromRoot is false, there's no overhead of calculating `originFromRoot_` field * the way originFromRoot is calculated: we first initialize `originFromRoot_` on the LayoutableShadowNode that enables `includeOriginFromRoot` (using `LayoutableShadowNode::computeRelativeLayoutMetrics`, which traverses all the ancestors), then calculate originFromRoot for children in its subtree recursively (`LayoutableShadowNode::computeOriginFromRoot` which only calculates by the difference from immediate parent) Differential Revision: D89573536
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Added] - optionally calculate originFromRoot for ShadowNode and pass to ShadowView
layout()withLayoutContext.includeOriginFromRoot==true, all its (recursive) children will calculateoriginFromRoot. This will be needed for shared transition/view transition, where we'll later need to know the absolute position of a shadowNode/shadowVieworiginFromRoot_fieldoriginFromRoot_on the LayoutableShadowNode that enablesincludeOriginFromRoot(usingLayoutableShadowNode::computeRelativeLayoutMetrics, which traverses all the ancestors), then calculate originFromRoot for children in its subtree recursively (LayoutableShadowNode::computeOriginFromRootwhich only calculates by the difference from immediate parent)Differential Revision: D89573536