fix(ios): missing cancel button when using popover action sheet (running on iPad or with SDK26 on iPhone)#55077
Conversation
|
Hi @mlisikbf! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1938640 to
ca7e043
Compare
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D90257007. |
|
For whatever reason, I am unable to reproduce today with the reproducer and a new, fresh project (both on latest RN). Will convert this to draft and continue testing. |
|
Closing as this was actually addressed in 0.83 via 82d2352 |
Summary:
Fixes #55074 by reverting to
UIAlertActionStyleDefaultfor iPad action sheet and iOS26 action sheet (meaning app was built with SDK26, is running on iOS26, and withoutUIDesignRequiresCompatibilityenabled).Changelog:
[IOS] [FIXED] - ActionSheet: prevent cancelButtonIndex from causing buttons to disappear when using popover action sheet
Test Plan:
Used https://github.com/mlisikbf/MobileTest_ActionSheet/tree/test-patch as a starting point. It has the change applied via patch-package, and uses action sheets with/without an anchor, and with/without cancelButtonIndex. Scenarios to test:
built with SDK26, running iOS26
Simulator.Screen.Recording.-.iPad.A16.-.2026-01-07.at.13.58.01.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-07.at.14.02.45.mov
built with SDK26, running iOS18
Simulator.Screen.Recording.-.iPad.mini.6th.generation.-.2026-01-07.at.14.25.21.mov
Simulator.Screen.Recording.-.iPhone.16.iOS.18.-.2026-01-07.at.14.25.09.mov
built with SDK 18, running iOS26
(cannot install older build tools atm, but this will be the same case as
UIDesignRequiresCompatibilitybelow)built with SDK26, running iOS26 with `UIDesignRequiresCompatibility`
Simulator.Screen.Recording.-.iPad.A16.-.2026-01-07.at.14.51.33.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-07.at.14.53.47.mov