Skip to content

Comments

Add claude md file for deprecated option removal#14360

Open
hx235 wants to merge 1 commit intofacebook:mainfrom
hx235:remove_option_md
Open

Add claude md file for deprecated option removal#14360
hx235 wants to merge 1 commit intofacebook:mainfrom
hx235:remove_option_md

Conversation

@hx235
Copy link
Contributor

@hx235 hx235 commented Feb 20, 2026

Context/Summary:

It's very easy to make mistake in removing deprecated option such as deleting the corresponding entry in type info that breaks backward compatibility or missing tests to test backward compatibility. Example: #14350 (comment). Added a claude md file for that.

Test:
In claude code, prompted for deprecated option removal with this claude md file in a repo separated from my previous deprecation efforts as much as possible and received correct change at one try.

@meta-cla meta-cla bot added the CLA Signed label Feb 20, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 20, 2026

@hx235 has imported this pull request. If you are a Meta employee, you can view this in D93920127.

Copy link
Contributor

@pdillinger pdillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Refer to claude_md/add_option.md

### Removing deprecated option
Refer to claude_md/remove_option.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this indirection keep from eating into the context budget when it's not relevant? I hope so because it's a lot of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants