Fix versionagedays() misparsing build time as a date - #1421
Open
vairakkumaarsvs wants to merge 1 commit into
Open
Fix versionagedays() misparsing build time as a date#1421vairakkumaarsvs wants to merge 1 commit into
vairakkumaarsvs wants to merge 1 commit into
Conversation
versionagedays() split the version string on "_" and always took index 1 as the YYYYMMDD build date. That index is only correct for the Buck build path (gen_version.py), which prepends a MAIN_VERSION component so the string is "x.y.z_YYYYMMDD_HHMMSS_hash" (date at index 1). The open-source build.py path's auto_version() omits that prefix, producing "YYYYMMDD_HHMMSS_hash" instead - so index 1 is actually the HHMMSS time portion, not the date. Because strptime's "%Y" greedily consumes exactly 4 digits, a 6-digit time string like "044315" doesn't fail to parse - it silently succeeds as year 0443, and the resulting multi-century "old version" hint gets shown even right after a fresh build. Scan for the first 8-digit, all-numeric "_"-delimited part instead of assuming a fixed index, so this works for both version string shapes.
|
This pull request has been imported. If you are a Meta employee, you can view this in D117323637. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
versionagedays() split the version string on "_" and always took index 1 as the YYYYMMDD build date. That index is only correct for the Buck build path (gen_version.py), which prepends a MAIN_VERSION component so the string is "x.y.z_YYYYMMDD_HHMMSS_hash" (date at index 1). The open-source build.py path's auto_version() omits that prefix, producing "YYYYMMDD_HHMMSS_hash" instead - so index 1 is actually the HHMMSS time portion, not the date.
Because strptime's "%Y" greedily consumes exactly 4 digits, a 6-digit time string like "044315" doesn't fail to parse - it silently succeeds as year 0443, and the resulting multi-century "old version" hint gets shown even right after a fresh build.
Scan for the first 8-digit, all-numeric "_"-delimited part instead of assuming a fixed index, so this works for both version string shapes.