fix: Stop perpetually skipping VeloxReaderTest.fsstStringBatchReader (#932)#932
Open
apurva-meta wants to merge 1 commit into
Open
fix: Stop perpetually skipping VeloxReaderTest.fsstStringBatchReader (#932)#932apurva-meta wants to merge 1 commit into
apurva-meta wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@apurva-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110523003. |
…acebookincubator#932) Summary: Context: The test-health monitor filed multiple SKIPPING issues (T278108817) for VeloxReaderTest.fsstStringBatchReader. The test GTEST_SKIP()s whenever optimizeStringBufferHandling is false (FSST is only produced by that encoding factory), and getTestParams() generates many optimize=false param instances, so those instances always skip and get flagged as unhealthy. This diff: Moves the test onto a new VeloxReaderFsstTest fixture that instantiates only the optimizeStringBufferHandling=true subset of params, so every instance actually runs instead of perpetually skipping. Drops the now-unnecessary skip guard. Reviewed By: HuamengJiang Differential Revision: D110523003
meta-codesync
Bot
changed the title
apurva-meta
force-pushed
the
export-D110523003
branch
from
4a3e99c to
23aa86e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
The test-health monitor filed multiple SKIPPING issues (T278108817) for
VeloxReaderTest.fsstStringBatchReader. The test GTEST_SKIP()s whenever
optimizeStringBufferHandling is false (FSST is only produced by that encoding
factory), and getTestParams() generates many optimize=false param instances, so
those instances always skip and get flagged as unhealthy.
This diff:
Moves the test onto a new VeloxReaderFsstTest fixture that instantiates only the
optimizeStringBufferHandling=true subset of params, so every instance actually
runs instead of perpetually skipping. Drops the now-unnecessary skip guard.
Reviewed By: HuamengJiang
Differential Revision: D110523003