Reserve serialized value buffers efficiently#942
Open
pankajsh909 wants to merge 1 commit into
Open
Conversation
Summary: Use the existing exact serialization-header size estimate to reserve known header bytes before writing, avoiding the previous 4 KB minimum allocation for tiny headers. Keep geometric growth for Vector<char> append paths where the full serialized stream payload is not known without buffering or a dry run. Add SerializationHeaderTest coverage for the Vector<char> header reservation path. Reviewed By: xiaoxmeng Differential Revision: D110654254
meta-cla
Bot
added
the
CLA Signed
|
@pankajsh909 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110654254. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Use the existing exact serialization-header size estimate to reserve known header bytes before writing, avoiding the previous 4 KB minimum allocation for tiny headers. Keep geometric growth for Vector append paths where the full serialized stream payload is not known without buffering or a dry run. Add SerializationHeaderTest coverage for the Vector header reservation path.
Reviewed By: xiaoxmeng
Differential Revision: D110654254