fix: Gate GooglePolyline and format Nimble tests#17831
Open
duxiao1212 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108570476. |
duxiao1212
force-pushed
the
export-D108570476
branch
from
bd76fe1 to
eadc3fa
Compare
Selective Build Plan
Affected targets (305)Directly changed (1)
Transitively affected (304)
Unresolved (1)These files could not be mapped to any target; a full build may be needed if they are build-relevant.
Slow path • Graph generated from PR branch |
CI Failure Analysis
❌ Linux release with adapters — TEST Failure View logsFailed tests: All 6 test cases fail with the same root cause — the shared library ( The same error occurs for all 6 missing
Failed test cases:
Correlation with PR changes: Root cause — selective build missing Known issues:
Reproduce locally: # Full build will pass because it builds the .so dependencies:
make release
cd _build/release && ctest -R velox_function_dynamic_link_test
# Or run the test binary directly:
./_build/release/velox/common/dynamic_registry/tests/velox_function_dynamic_link_testRecommended fix: |
Summary: X-link: facebookincubator/nimble#868 Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, declare the direct geo dependencies explicitly, and apply clang-format fixes required by the Nimble GitHub pre-commit job. Differential Revision: D108570476
duxiao1212
force-pushed
the
export-D108570476
branch
from
eadc3fa to
052098a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/nimble#868
Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, declare the direct geo dependencies explicitly, and apply clang-format fixes required by the Nimble GitHub pre-commit job.
Differential Revision: D108570476