Fix ai_wdl sub-benchmark consistency and error handling#503
Open
YifanYuan3 wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Fix ai_wdl sub-benchmark consistency and error handling#503YifanYuan3 wants to merge 1 commit intofacebookresearch:v2-betafrom
YifanYuan3 wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
Summary: Fixes error handling and path resolution issues across ai_wdl sub-benchmarks (fbgemm, rebatch, type_conversion, chm, deser). This diff: - Fix `|| exist` typos to `|| exit 1` in install_fbgemm_bench.sh (4 occurrences). Typo causes silent failure when pushd fails. - Fix hardcoded $(pwd)-based paths in rebatch and type_conversion install scripts. Replace with dirname/readlink pattern so scripts work when invoked from any directory. - Add `|| exit 1` to pushd in chm and deser install scripts to fail fast if folly directory doesn't exist. Differential Revision: D95510128
meta-cla
bot
added
the
CLA Signed
|
@YifanYuan3 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95510128. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
Summary: Pull Request resolved: #503 Fixes error handling and path resolution issues across ai_wdl sub-benchmarks (fbgemm, rebatch, type_conversion, chm, deser). This diff: - Fix `|| exist` typos to `|| exit 1` in install_fbgemm_bench.sh (4 occurrences). Typo causes silent failure when pushd fails. - Fix hardcoded $(pwd)-based paths in rebatch and type_conversion install scripts. Replace with dirname/readlink pattern so scripts work when invoked from any directory. - Add `|| exit 1` to pushd in chm and deser install scripts to fail fast if folly directory doesn't exist. Reviewed By: excelle08 Differential Revision: D95510128 fbshipit-source-id: 9239b6a3992563b951de0fa98a2542b28c7ed532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes error handling and path resolution issues across ai_wdl sub-benchmarks (fbgemm, rebatch, type_conversion, chm, deser).
This diff:
|| existtypos to|| exit 1in install_fbgemm_bench.sh (4 occurrences). Typo causes silent failure when pushd fails.|| exit 1to pushd in chm and deser install scripts to fail fast if folly directory doesn't exist.Differential Revision: D95510128