Fix feedsim install script idempotency and version mismatches#512
Open
YifanYuan3 wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Fix feedsim install script idempotency and version mismatches#512YifanYuan3 wants to merge 1 commit intofacebookresearch:v2-betafrom
YifanYuan3 wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
Summary:
Fixes issues that cause feedsim install scripts to fail on re-runs and waste time reinstalling dependencies that are already present.
This diff:
- Fix libevent version mismatch: 3 scripts check for `libevent-2.1.11-stable` but download `2.1.12`, causing unnecessary reinstallation every run. Update checks to match downloaded version.
- Add idempotency guards around fast_float clone (fails on re-run if directory exists).
- Add idempotency guards around submodule clone loop (match aarch64 script pattern).
- Remove dead aarch64 LibTorch URL branches from x86-only scripts (unreachable code).
- Remove commented-out trap handlers and dead cleanup() functions.
- Fix BP_CC/BP_CXX to use `${BP_CC:-gcc}` instead of hardcoded override (respect env vars).
Differential Revision: D95510167
meta-cla
bot
added
the
CLA Signed
|
@YifanYuan3 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95510167. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Summary: Pull Request resolved: #512 Fixes issues that cause feedsim install scripts to fail on re-runs and waste time reinstalling dependencies that are already present. This diff: - Fix libevent version mismatch: 3 scripts check for `libevent-2.1.11-stable` but download `2.1.12`, causing unnecessary reinstallation every run. Update checks to match downloaded version. - Add idempotency guards around fast_float clone (fails on re-run if directory exists). - Add idempotency guards around submodule clone loop (match aarch64 script pattern). - Remove dead aarch64 LibTorch URL branches from x86-only scripts (unreachable code). - Remove commented-out trap handlers and dead cleanup() functions. - Fix BP_CC/BP_CXX to use `${BP_CC:-gcc}` instead of hardcoded override (respect env vars). Reviewed By: excelle08 Differential Revision: D95510167 fbshipit-source-id: 66941434890c975b70b39660d2a7d24fe72a0dfa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes issues that cause feedsim install scripts to fail on re-runs and waste time reinstalling dependencies that are already present.
This diff:
libevent-2.1.11-stablebut download2.1.12, causing unnecessary reinstallation every run. Update checks to match downloaded version.${BP_CC:-gcc}instead of hardcoded override (respect env vars).Differential Revision: D95510167