Open
Conversation
Contributor
|
@mnorris11 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95573957. |
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Mar 6, 2026
Summary: Upgrades Faiss CUVS builds from C++17 to C++20 by updating cuVS/RAPIDS from version 25.10 to 26.02, which includes C++20 support (tracked in rapidsai/cuvs#1659). Changes: - Remove the C++17 exception for CUVS in both `public_tld/CMakeLists.txt` and `python/CMakeLists.txt`, making C++20 unconditional across all platforms - Upgrade RAPIDS_VERSION from 25.10 to 26.02 in `fetch_rapids.cmake` - Update libcuvs version pins from 25.10 to 26.02 in conda `meta.yaml` and CI `build_cmake/action.yml` - Update INSTALL.md to reflect the new cuVS version and C++20 compiler requirement This completes the C++20 migration for Faiss — previously OSX and CUVS were excluded (D84842523), OSX was fixed in D89523723, and now CUVS is upgraded as well. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=00ba3fbe-eeca-4a54-aff4-a6b6d9c3c750) Differential Revision: D95573957
mnorris11
force-pushed
the
export-D95573957
branch
from
8cf1909 to
8d4f716
Compare
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Mar 7, 2026
Summary: Upgrades Faiss CUVS builds from C++17 to C++20 by updating cuVS/RAPIDS from version 25.10 to 26.02, which includes C++20 support (tracked in rapidsai/cuvs#1659). Changes: - Remove the C++17 exception for CUVS in both `public_tld/CMakeLists.txt` and `python/CMakeLists.txt`, making C++20 unconditional across all platforms - Upgrade RAPIDS_VERSION from 25.10 to 26.02 in `fetch_rapids.cmake` - Update libcuvs version pins from 25.10 to 26.02 in conda `meta.yaml` and CI `build_cmake/action.yml` - Update INSTALL.md to reflect the new cuVS version and C++20 compiler requirement This completes the C++20 migration for Faiss — previously OSX and CUVS were excluded (D84842523), OSX was fixed in D89523723, and now CUVS is upgraded as well. Differential Revision: D95573957
mnorris11
force-pushed
the
export-D95573957
branch
from
8d4f716 to
21a6ba4
Compare
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Mar 7, 2026
Summary: Upgrades Faiss CUVS builds from C++17 to C++20 by updating cuVS/RAPIDS from version 25.10 to 26.02, which includes C++20 support (tracked in rapidsai/cuvs#1659). Changes: - Remove the C++17 exception for CUVS in both `public_tld/CMakeLists.txt` and `python/CMakeLists.txt`, making C++20 unconditional across all platforms - Upgrade RAPIDS_VERSION from 25.10 to 26.02 in `fetch_rapids.cmake` - Update libcuvs version pins from 25.10 to 26.02 in conda `meta.yaml` and CI `build_cmake/action.yml` - Update INSTALL.md to reflect the new cuVS version and C++20 compiler requirement This completes the C++20 migration for Faiss — previously OSX and CUVS were excluded (D84842523), OSX was fixed in D89523723, and now CUVS is upgraded as well. Differential Revision: D95573957
mnorris11
force-pushed
the
export-D95573957
branch
from
21a6ba4 to
f0eabba
Compare
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Mar 7, 2026
Summary: Upgrades Faiss CUVS builds from C++17 to C++20 by updating cuVS/RAPIDS from version 25.10 to 26.02, which includes C++20 support (tracked in rapidsai/cuvs#1659). Changes: - Remove the C++17 exception for CUVS in both `public_tld/CMakeLists.txt` and `python/CMakeLists.txt`, making C++20 unconditional across all platforms - Upgrade RAPIDS_VERSION from 25.10 to 26.02 in `fetch_rapids.cmake` - Update libcuvs version pins from 25.10 to 26.02 in conda `meta.yaml` and CI `build_cmake/action.yml` - Update INSTALL.md to reflect the new cuVS version and C++20 compiler requirement This completes the C++20 migration for Faiss — previously OSX and CUVS were excluded (D84842523), OSX was fixed in D89523723, and now CUVS is upgraded as well. Differential Revision: D95573957
mnorris11
force-pushed
the
export-D95573957
branch
from
f0eabba to
fcfd3fb
Compare
Summary: Upgrades Faiss CUVS builds from C++17 to C++20 by updating cuVS/RAPIDS from version 25.10 to 26.02, which includes C++20 support (tracked in rapidsai/cuvs#1659). Changes: - Remove the C++17 exception for CUVS in both `public_tld/CMakeLists.txt` and `python/CMakeLists.txt`, making C++20 unconditional across all platforms - Upgrade RAPIDS_VERSION from 25.10 to 26.02 in `fetch_rapids.cmake` and changed the branch to https://raw.githubusercontent.com/rapidsai/rapids-cmake/release/26.02/RAPIDS.cmake. (Claude couldn't figure this out because no internet access...) - Update libcuvs version pins from 25.10 to 26.02 in conda `meta.yaml` and CI `build_cmake/action.yml` - Update INSTALL.md to reflect the new cuVS version and C++20 compiler requirement This completes the C++20 migration for Faiss — previously OSX and CUVS were excluded (D84842523), OSX was fixed in D89523723, and now CUVS is upgraded as well. Differential Revision: D95573957
mnorris11
force-pushed
the
export-D95573957
branch
from
fcfd3fb to
a75a674
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrades Faiss CUVS builds from C++17 to C++20 by updating cuVS/RAPIDS from version 25.10 to 26.02, which includes C++20 support (tracked in rapidsai/cuvs#1659).
Changes:
public_tld/CMakeLists.txtandpython/CMakeLists.txt, making C++20 unconditional across all platformsfetch_rapids.cmakemeta.yamland CIbuild_cmake/action.ymlThis completes the C++20 migration for Faiss — previously OSX and CUVS were excluded (D84842523), OSX was fixed in D89523723, and now CUVS is upgraded as well.
Differential Revision: D95573957