Skip to content

Fix Issue 16 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
edelciomolina wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix Issue 16 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560a920
NUglify updated from 1.17.10 to 1.20.4
edelciomolina Jan 4, 2023
3635ec5
Add: Test for Support Vue Shorthand Event Syntax [WIP]
edelciomolina Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BundlerMinifier.Core/BundlerMinifier.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NUglify" Version="1.17.10" />
<PackageReference Include="NUglify" Version="1.20.4" />
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/BundlerMinifier/BundlerMinifier.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<PackageReference Include="Microsoft.Build.Framework" Version="15.1.0-*" PrivateAssets="All" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.1.0-*" PrivateAssets="All" />
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" PrivateAssets="All" />
<PackageReference Include="NUglify" Version="1.17.10" PrivateAssets="All" />
<PackageReference Include="NUglify" Version="1.20.4" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
Expand Down
1 change: 1 addition & 0 deletions src/BundlerMinifierTest/BundlerMinifierTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
</ItemGroup>

<ItemGroup>
<None Remove="artifacts\file5.html" />
<None Remove="artifacts\file5.js" />
</ItemGroup>

Expand Down
11 changes: 11 additions & 0 deletions src/BundlerMinifierTest/BundlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,17 @@ public void SupportNewSyntax()
Assert.AreEqual("function test(n){for(const t of n)console.log(t)}test([1,2,3,4]);", jsResult);
}

[TestMethod]
public void SupportVueShorthandEventSyntax()
{
//https://vuejs.org/guide/essentials/template-syntax.html#arguments
_processor.Process(TEST_BUNDLE.Replace("test1", "test10"));

string jsResult = File.ReadAllText("../../../artifacts/test10.min.html");

Assert.AreEqual("<v-autocomplete ref=\"peopleSearch\" clearable :items=\"peopleSearch_Items\" :loading=\"peopleSearch_Loading\" :label=\"peopleSearch_Label\" :no-data-text=\"peopleSearch_NoData\" v-model=\"peopleSearch\" v-model:search=\"peopleSearch_Search\" item-title=\"text\" item-value=\"id\" variant=\"underlined\" placeholder=\"Digite para pesquisar\" @keydown.enter=\"peopleSearch_EnterPressed(this, peopleSearch_Items[0])\" return-object></v-autocomplete>", jsResult);
}

[TestMethod]
public void SupportDoubleAsteriskOperator()
{
Expand Down
15 changes: 15 additions & 0 deletions src/BundlerMinifierTest/artifacts/file5.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<v-autocomplete ref="peopleSearch"
clearable
:items="peopleSearch_Items"
:loading="peopleSearch_Loading"
:label="peopleSearch_Label"
:no-data-text="peopleSearch_NoData"
v-model="peopleSearch"
v-model:search="peopleSearch_Search"
item-title="text"
item-value="id"
variant="underlined"
placeholder="Digite para pesquisar"
@keydown.enter="peopleSearch_EnterPressed(this, peopleSearch_Items[0])"
return-object>
</v-autocomplete>
12 changes: 12 additions & 0 deletions src/BundlerMinifierTest/artifacts/test10.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[
{
"outputFileName": "file5.min.html",
"inputFiles": [
"file5.html"
],
"minify": {
"enabled": true,
"removeHtmlComments": true
}
}
]
2 changes: 1 addition & 1 deletion src/BundlerMinifierVsix/BundlerMinifierVsix.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@
<Version>3.5.0</Version>
</PackageReference>
<PackageReference Include="NUglify">
<Version>1.17.10</Version>
<Version>1.20.4</Version>
</PackageReference>
</ItemGroup>
<!-- end workaround -->
Expand Down