feat: de-proxy locale access

[ST-DDT]

Second part of the standalone module function feature #2667

• Proposal: Design for standalone module functions #2667

Fixes #3155

• Support older browsers without Proxy #3155

Requires #2838

• feat: introduce FakerCore #2838

Overview

1. Introduce FakerCore feat: introduce FakerCore #2838
2. De-proxy locale access feat: de-proxy locale access #3189
3. De-class config function feat: standalone module functions #3748 (seed, setDefaultRefDate, ...)
4. De-module functions feat: standalone module functions #3748 (airline, ...)

Description

Instead of calling this.faker.definitions.category.entry, we will now use resolveLocaleData(this.faker.fakerCore, 'category', 'entry').
Please note that this will get simplified with the next PR as this.faker.fakerCore will get replaced with just fakerCore.
This change makes the functions independent from the main faker instance, at least locale access wise.
That makes resolveLocaleData the first effective "standalone module function", as it no longer needs faker, only the fakerCore is needed.

As an additional benefit it also fixes #3155

• Support older browsers without Proxy #3155 (as long as the full faker instance isn't created/the faker.definitions isn't accessed (when using lazy loading))

Recreating the PR

• Cherry-pick the first and second commit.
• Replace this.faker\.definitions\.(\w+)\.(\w+) with resolveLocaleData(this.faker.fakerCore, '$1', '$2') in src.
• Replace faker\.definitions\.(\w+)\.(\w+) with resolveLocaleData(faker.fakerCore, '$1', '$2') in src.
• Replace faker\.definitions\.(\w+)\??\.(\w+) with resolveLocaleData(faker.fakerCore, '$1', '$2') in test.
• Replace faker\.definitions\.(\w+)\[(\w+)\] with resolveLocaleData(faker.fakerCore, '$1', $2) in test.
• Add missing imports
• Revert faker.spec.ts
• Cherry-pick the manual patches.

Next Steps (Future PR)

The next step after this PR is converting the other methods to standalone module functions.

Current

export class AirlineModule extends ModuleBase {
  airport(): Airport {
    return this.faker.helpers.arrayElement(
      resolveLocaleData(this.faker.fakerCore, 'airline', 'airport')
    );
  }
}

Future

function airport(fakerCore: FakerCore): Airport {
  return arrayElement(fakerCore, 
    resolveLocaleData(fakerCore, 'airline', 'airport')
  );
}

export class AirlineModule extends ModuleBase {
  airport(): Airport {
    // return airport(this.faker.fakerCore);
    return airport(this.fakerCore);
  }
}

[codecov]

Codecov Report

❌ Patch coverage is 98.40256% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.96%. Comparing base (ba4ef9a) to head (c67f876).
⚠️ Report is 457 commits behind head on next.

Files with missing lines	Patch %	Lines
src/modules/person/index.ts	82.14%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #3189      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2798     2801       +3     
  Lines      227375   227531     +156     
  Branches      956      960       +4     
==========================================
+ Hits       227310   227461     +151     
- Misses         65       70       +5     

Files with missing lines	Coverage Δ
src/config.ts	100.00% <100.00%> (ø)
src/core.ts	100.00% <100.00%> (ø)
src/definitions/definitions.ts	100.00% <ø> (ø)
src/faker.ts	100.00% <100.00%> (ø)
src/index.ts	100.00% <ø> (ø)
src/internal/locale-proxy.ts	100.00% <100.00%> (ø)
src/modules/airline/index.ts	100.00% <100.00%> (ø)
src/modules/animal/index.ts	100.00% <100.00%> (ø)
src/modules/book/index.ts	100.00% <100.00%> (ø)
src/modules/color/index.ts	100.00% <100.00%> (ø)
... and 22 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ST-DDT]

Should I push this PR forward (as a pre-step of #3748) or should I drop it in favor of #3748 (or its parts)?
(Affects all modules that have locale files, could likely be split into one PR per module as well)

TLDR: This PR intends to do:

• Replace this.faker\.definitions\.(\w+)\.(\w+) and similar
  with assertLocaleData(this.faker.fakerCore.locale.$1.$2, '$1.$2')

#3748 does the same just with this.faker.fakerCore -> fakerCore (during the move to separate files).

[Shinigami92]

Should I push this PR forward (as a pre-step of #3748) or should I drop it in favor of #3748 (or its parts)? [...]

• feat: standalone module functions #3748 touches 359 files right now, that are at least 259 files to much for me to make a proper review
  so everything that helps to chunk the PRs down to <100 touched files per PR is a win for reviewers

[matthewmayer]

Agreed, if there are ways to chunk the more mechanical changes into seperate PRs like this that make the final PR smaller, and it doesn't break the build, then go for it.