Open
Conversation
chamini2
reviewed
Nov 17, 2025
|
|
||
| def is_expired(self) -> bool: | ||
| return datetime.now(timezone.utc) >= self.expires_at | ||
| def is_expired(self, offset: timedelta | int | None = None) -> bool: |
Member
There was a problem hiding this comment.
I am thinking we may want to add a default value of 1h or smth
Author
There was a problem hiding this comment.
That seems reasonable to me (though we'd probably want to add that on get_token rather than is_expired)
efiop
approved these changes
Nov 28, 2025
This commit adds a new `valid_for` parameter that allows callers to assert that a CDN token should be valid for a specified time period.
nzentzis
force-pushed
the
noahz/add-valid-time
branch
from
b8a5655 to
3c484ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new
valid_forparameter that allows callers to assert that a CDN token should be valid for a specified time period.