setup.py : Clarify the encoding when reading a file#98
Open
lilacs2039 wants to merge 1 commit intofastai:masterfrom
Open
setup.py : Clarify the encoding when reading a file#98lilacs2039 wants to merge 1 commit intofastai:masterfrom
lilacs2039 wants to merge 1 commit intofastai:masterfrom
Conversation
Problem : With the created package, `pip install` fails on Windows Fixes : Clarified the encoding for file reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment
Windows 10 Pro
Problem
When I tried to
pip installthe package I created, the following encoding error occured.Error Message
(Partially abbreviated in
...)Cause
Because the standard input / output of Windows is CP 932, the error occurred while reading a UTF-8 file.
Fixes
Because
README.mdandsettings.iniare in UTF-8 encoding, clarified the encoding when reading the file.