Implemented checkSSL#1441
Open
pablodelolmo wants to merge 3 commits intofastly:mainfrom
Open
Conversation
Like we currently do in Delivery services, have this parameter when defining a Backend takes care of the behind the scenes to disable backend server validation.
zkat
reviewed
Apr 23, 2026
| { | ||
| "name": "@fastly/js-compute", | ||
| "version": "3.41.1", | ||
| "version": "3.41.2", |
Member
There was a problem hiding this comment.
we'll bump this ourselves, no need to do it in your PR.
| }); | ||
| }, | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Can you add a test that actually hits https://http-me.fastly.dev?
- Added different tests sets for the checkSSL feature, covering expired, wrong hostname and self signed certs. - Reverted package version bumps.
Contributor
Author
|
Added three sets of tests for three different scenarios. The scenarios are:
The set of tests for each one are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale behind this PR
One of the features currently present in our delivery services when defining backend is the possibility to disable TLS certificate validation when reaching backends (see
ssl_check_certin our API docs). We currently support that in our Compute platform but the way of doing it is to not define the backend certificate fields such assniHostname,certificateHostnameandcaCertificate. The intention of adding this is to have the same explicit field and handle the behind the scenes removal of those fields when dealing with the Compute runtime.What's in this PR