Open
Conversation
iDreamsOfGame
commented
Jan 25, 2024
iDreamsOfGame
commented
- Fixed error of Ondin Inspector 3.1.x.
- Fixed bug that AddressableImportSettingsList.RebuildSettingsList doesn't save.
favoyang
requested changes
Jan 25, 2024
| [Tooltip("Rules for managing imported assets.")] | ||
| #if ODIN_INSPECTOR | ||
| [ListDrawerSettings(HideAddButton = false,Expanded = false,DraggableItems = true,HideRemoveButton = false)] | ||
| #if ODIN_INSPECTOR |
Owner
There was a problem hiding this comment.
Seems the #ODIN_INSPECTOR should be versioned.
Author
There was a problem hiding this comment.
Yep, different API in different version.
Owner
There was a problem hiding this comment.
Okay, please change the related symbol to be versioned (#ODIN_INSPECTOR_X_Y_Z)
Owner
There was a problem hiding this comment.
@iDreamsOfGame my point is that your patch contains two duplicated #if ODIN_INSPECTOR symbol (a typo?), the second one should be a versioned symbol.
#if ODIN_INSPECTOR
#if ODIN_INSPECTOR <-- should be versioned like #if ODIN_INSPECTOR_X_Y_Z
...
#else
...
#endif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.