Open
Conversation
|
👍 |
|
Sweet. Please release to fix #65. |
|
|
|
I've forked this repo to https://github.com/smoketurner/dropwizard-swagger and plan to publish it to maven central under the "com.smoketurner" groupId if anyone is interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having run into an issue #65 an
IllegalArgumentExceptionis thrown when anOptionalargument is in an annotated method signature . I found by upgrading to the latest Swagger2 api v1.5.0 the issue apparently vanishes.This PR also covers the request for the v1.5.0 upgrade #58 but seems to supersedes plans for a more thorough Swagger2 integration #22. Given that this is a response to a BUG in the previous version of swagger the PR should be considered on those grounds.
I did find that the new version of the API introduces an annoying runtime dependency,
org.glassfish.jersey.media.multipart.FormDataParam,which had to be declared in the build independently.