Skip to content

feat: add is_mapping typing helper#83

Open
msto wants to merge 1 commit into
msto/delimited-converter-basefrom
msto/is-mapping-helper
Open

feat: add is_mapping typing helper#83
msto wants to merge 1 commit into
msto/delimited-converter-basefrom
msto/is-mapping-helper

Conversation

@msto

@msto msto commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR is the fourth in a stack to expand Metric's collection parsing behavior to support tuple, set, and dict along with the existing list support, to provide parity with fgpyo.

This PR simply adds a small is_mapping helper that identified dict[K, V] types. It's added in its own PR to make the ensuing PR (which adds DelimitedMapping) easier to review.

Related Stack

Add an is_mapping introspection helper that identifies parameterized dict[K, V]
types (including the optional form), excluding Counter, which has a distinct
origin and is handled separately. Foundation for the forthcoming
DelimitedMapping converter.

Relates to #76.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@msto msto self-assigned this Jun 17, 2026
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@msto, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 58 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a7fdc633-06ef-4e34-a750-5e78fefda538

📥 Commits

Reviewing files that changed from the base of the PR and between 2615c70 and 1e12346.

📒 Files selected for processing (2)
  • fgmetric/_typing_extensions.py
  • tests/test_typing_extensions.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msto

msto commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant