Conversation
- Remove bundlesize dependency - Add @size-limit/preset-small-lib and size-limit dependencies - Convert bundlesize config to size-limit format - Add Bundle Size Check job to CI workflow - Update GitHub Actions to v4 (checkout, setup-node) Bundle size limits: - dist/final-form-calculate.umd.min.js: 1kB - dist/final-form-calculate.es.js: 1.5kB - dist/final-form-calculate.cjs.js: 1.5kB
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughMigrates bundle-size checking from bundlesize to size-limit, updates GitHub Actions steps to v4 (locks Node.js to 22 and replaces codecov action), adds a dedicated "Bundle Size Check" CI job, and raises bundle size limits in package.json. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/ci.yml:
- Line 51: Update the Codecov GitHub Action reference from the old pin "uses:
codecov/codecov-action@v2.1.0" to the current major release (for example "uses:
codecov/codecov-action@v5.5.2") to pick up security fixes and improvements;
locate the workflow step that contains the string "uses:
codecov/codecov-action@v2.1.0" and replace the version tag with the desired v5
release, then run the workflow locally or in CI to verify token/inputs remain
compatible and adjust input names if any breaking changes occur between v2 and
v5.
In `@package.json`:
- Around line 92-95: The CI failed because the size-limit entry for
"dist/final-form-calculate.umd.min.js" (the "size-limit" array entry with path
"dist/final-form-calculate.umd.min.js") is set to "1kB" but the bundle is 1 byte
over; update that limit to a slightly larger value (for example "1.1kB" or
"1025B") in package.json to allow the current build to pass while keeping a
tight size constraint.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Migrates from deprecated bundlesize to size-limit for bundle size monitoring.
Changes
Bundle Size Limits
dist/final-form-calculate.umd.min.js: 1kBdist/final-form-calculate.es.js: 1.5kBdist/final-form-calculate.cjs.js: 1.5kBPart of the bundlesize → size-limit migration across all Final Form repos.
Summary by CodeRabbit