Skip to content

bug/vendor-credit-account-id#207

Merged
fivetran-catfritz merged 9 commits into
mainfrom
bug/vendor-credit-account-id
Jun 3, 2026
Merged

bug/vendor-credit-account-id#207
fivetran-catfritz merged 9 commits into
mainfrom
bug/vendor-credit-account-id

Conversation

@fivetran-catfritz

@fivetran-catfritz fivetran-catfritz commented May 26, 2026

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • v1.7.0-a1
  • v.1.6.2

This PR addresses the following Issue/Feature(s):

  • GA-1026684

Summary of changes:

  • Corrects vendor credit account selection in int_quickbooks__vendor_credit_double_entry to prioritize expense accounts over income accounts in the credit_account_id field, improving accounting accuracy for vendor credit transactions.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this May 26, 2026
@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label May 26, 2026
@fivetran-catfritz fivetran-catfritz added the pre-release Triggers the auto-releaser workflow. label May 27, 2026
@fivetran-catfritz fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. labels Jun 3, 2026
@fivetran-catfritz fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jun 3, 2026
github-actions Bot and others added 4 commits June 3, 2026 19:42
Updated vendor credit account selection logic in `int_quickbooks__vendor_credit_double_entry` to prioritize expense accounts, enhancing accuracy for vendor credit transactions.
@fivetran-catfritz fivetran-catfritz merged commit 23e20c2 into main Jun 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants