Add inventory model#208
Open
fivetran-avinash wants to merge 13 commits into
Open
Conversation
fivetran-savage
left a comment
fivetran-savage
left a comment
Contributor
There was a problem hiding this comment.
Couple of suggestions for the yml documentation, but the main thing is that the package doesn't currently run with the using_purchase variable set to false. I left a more detailed comment with some ideas in the ticket. Let me know if you want to talk anything through on Monday.
| - name: transaction_type | ||
| description: The source transaction type (invoice, bill, purchase, sales_receipt, credit_memo, refund_receipt, vendor_credit, purchase_order). | ||
| - name: transaction_id | ||
| description: Unique identifier of the parent transaction. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: Unique identifier of the parent transaction. | |
| description: "{{ doc('transaction_id') }}") |
Contributor
There was a problem hiding this comment.
Matches other transaction_id fields in yml
| - name: doc_number | ||
| description: Reference number for the transaction, as shown in QuickBooks reports. | ||
| - name: transaction_date | ||
| description: Date the transaction occurred. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: Date the transaction occurred. | |
| description: "{{ doc('transaction_date') }}" |
Contributor
There was a problem hiding this comment.
Matches other transaction_date fields in yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog