Skip to content

Use public URL for webhook e2e tests #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fivetran-jovanmanojlovic merged 2 commits into from
Jun 8, 2026
Merged

Use public URL for webhook e2e tests #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b3ef3
Use public URL for webhook e2e tests
fivetran-jovanmanojlovic Jun 5, 2026
35b8e61
Align destination list e2e DST assertion
fivetran-jovanmanojlovic Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test_utils/test_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ func DeleteWebhook(t *testing.T, id string) {
func CreateWebhookAccount(t *testing.T) string {
t.Helper()
created, err := Client.NewWebhookAccountCreate().
Url("https://localhost:12345").
Url("https://example.com").
Secret("my_secret").
Active(false).
Events([]string{"sync_start", "sync_end"}).
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/destinations_list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func TestNewDestinationsListE2E(t *testing.T) {
testutils.AssertEqual(t, result.Data.Items[0].Service, "snowflake")
testutils.AssertEqual(t, result.Data.Items[0].Region, "GCP_US_EAST4")
testutils.AssertEqual(t, result.Data.Items[0].TimeZoneOffset, "+10")
testutils.AssertEqual(t, result.Data.Items[0].DaylightSavingTimeEnabled, false)
testutils.AssertEqual(t, result.Data.Items[0].DaylightSavingTimeEnabled, true)
testutils.AssertEmpty(t, result.Data.Items[0].PrivateLinkId)
testutils.AssertEmpty(t, result.Data.Items[0].ProxyAgentId)
testutils.AssertEmpty(t, result.Data.Items[0].HybridDeploymentAgentId)
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/webhook_account_create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestNewWebhookAccountCreateE2E(t *testing.T) {
created, err := testutils.Client.NewWebhookAccountCreate().
Url("https://localhost:12345").
Url("https://example.com").
Secret("my_secret").
Active(false).
Events([]string{"sync_start", "sync_end"}).
Expand All @@ -29,7 +29,7 @@ func TestNewWebhookAccountCreateE2E(t *testing.T) {
testutils.AssertEqual(t, created.Data.Type, "account")
testutils.AssertEqual(t, created.Data.Active, false)
testutils.AssertEqual(t, created.Data.Secret, "******")
testutils.AssertEqual(t, created.Data.Url, "https://localhost:12345")
testutils.AssertEqual(t, created.Data.Url, "https://example.com")
testutils.AssertEqual(t, created.Data.Events, []string{"sync_start", "sync_end"})

t.Cleanup(func() { testutils.DeleteWebhook(t, created.Data.Id) })
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/webhook_details_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func TestWebhookDetailsE2E(t *testing.T) {
testutils.AssertEmpty(t, result.Data.GroupId)
testutils.AssertEqual(t, result.Data.Type, "account")
testutils.AssertEqual(t, result.Data.Secret, "******")
testutils.AssertEqual(t, result.Data.Url, "https://localhost:12345")
testutils.AssertEqual(t, result.Data.Url, "https://example.com")
testutils.AssertEqual(t, result.Data.Events, []string{"sync_start", "sync_end"})
testutils.AssertEqual(t, result.Data.Active, false)

Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/webhook_group_create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestNewWebhookGroupCreateE2E(t *testing.T) {
created, err := testutils.Client.NewWebhookGroupCreate().
Url("https://localhost:12345").
Url("https://example.com").
Secret("my_secret").
GroupId(testutils.PredefinedGroupId).
Active(false).
Expand All @@ -31,7 +31,7 @@ func TestNewWebhookGroupCreateE2E(t *testing.T) {
testutils.AssertEqual(t, created.Data.Active, false)
testutils.AssertEqual(t, created.Data.GroupId, testutils.PredefinedGroupId)
testutils.AssertEqual(t, created.Data.Secret, "******")
testutils.AssertEqual(t, created.Data.Url, "https://localhost:12345")
testutils.AssertEqual(t, created.Data.Url, "https://example.com")
testutils.AssertEqual(t, created.Data.Events, []string{"sync_start", "sync_end"})

t.Cleanup(func() { testutils.DeleteWebhook(t, created.Data.Id) })
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/webhook_update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ func TestWebhookUpdateE2E(t *testing.T) {

updated, err := testutils.Client.NewWebhookUpdate().
WebhookId(webhookId).
Url("https://localhost:12345").
Url("https://example.com").
Secret("my_secret").
Active(false).
Events([]string{"sync_start", "sync_end"}).
Expand All @@ -31,7 +31,7 @@ func TestWebhookUpdateE2E(t *testing.T) {
testutils.AssertNotEmpty(t, updated.Data.Type)
testutils.AssertEqual(t, updated.Data.Active, false)
testutils.AssertEqual(t, updated.Data.Secret, "******")
testutils.AssertEqual(t, updated.Data.Url, "https://localhost:12345")
testutils.AssertEqual(t, updated.Data.Url, "https://example.com")
testutils.AssertEqual(t, updated.Data.Events, []string{"sync_start", "sync_end"})

t.Cleanup(func() { testutils.DeleteWebhook(t, webhookId) })
Expand Down
Loading