Add connector metadata field status#146
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the connector metadata model to deserialize a new fieldStatus attribute on metadata.Property, and updates the metadata details test fixture/assertions accordingly. It also records the change in the changelog as part of a new 1.3.5 entry.
Changes:
- Added
FieldStatustometadata.Propertywith JSON tagfieldStatus. - Updated
metadata_details_test.gomock response JSON and assertions to coverfieldStatuson various properties. - Updated
CHANGELOG.mdwith an Unreleased compare link bump and a1.3.5“Added” entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| metadata/common_types.go | Adds Property.FieldStatus to support deserializing the new metadata field. |
| metadata/metadata_details_test.go | Extends the test JSON fixture and assertions to validate fieldStatus deserialization. |
| CHANGELOG.md | Documents the addition under version 1.3.5 and updates the Unreleased compare link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fivetran-renat-sh
approved these changes
Jun 17, 2026
fivetran-renat-sh
left a comment
fivetran-renat-sh
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thank you!
Might want to postpone release until API changes are available on prod. But probably can be merged right away though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.