fix: Notify the component when ColorEffect resets its color filter - #4044
Draft
spydon wants to merge 2 commits into
Draft
fix: Notify the component when ColorEffect resets its color filter#4044spydon wants to merge 2 commits into
spydon wants to merge 2 commits into
Conversation
spydon
force-pushed
the
fix/color-effect-reset-notifies
branch
from
September 8, 2026 19:47
abc6838 to
b79059a
Compare
spydon
force-pushed
the
fix/text-component-opacity-shadows
branch
from
September 8, 2026 19:47
5334a1f to
8ae253e
Compare
spydon
force-pushed
the
fix/text-component-opacity-shadows
branch
from
September 8, 2026 20:10
8ae253e to
8d51db4
Compare
spydon
force-pushed
the
fix/color-effect-reset-notifies
branch
from
September 8, 2026 20:10
b79059a to
57eb69c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #4043.
ColorEffect.reset()restored the original color filter directly on the paint without callingHasPaint.onChanged(). Components that derive their rendering from the paint, such asTextComponent, therefore kept the last tint after the effect was reset, until something elsechanged the paint.
reset()now callsonChanged()after restoring the color filter, in line withtint,setColorand the opacity setter in
HasPaint.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Related to #4013 and #4043.