fix: reject pluginId in rule creator about metadata

[tylerlaprade]

PR Checklist

• Addresses an existing open issue: fixes 🐛 Bug: rule creator instances allow overrides on about.pluginId #3051
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

RuleAbout now describes the metadata passed to RuleCreator, while PluginRuleAbout adds the pluginId and url that the creator supplies.

[netlify]

✅ Deploy Preview for flint-fyi ready!

Name	Link
🔨 Latest commit	b092a80
🔍 Latest deploy log	https://app.netlify.com/projects/flint-fyi/deploys/6a99d9cdc813ac00086e45df
😎 Deploy Preview	https://deploy-preview-3364--flint-fyi.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[changeset-bot]

🦋 Changeset detected

Latest commit: b092a80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@flint.fyi/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

@flint.fyi/astro

pnpm add https://pkg.pr.new/@flint.fyi/astro@b092a80 -D

@flint.fyi/astro-language

pnpm add https://pkg.pr.new/@flint.fyi/astro-language@b092a80 -D

@flint.fyi/browser

pnpm add https://pkg.pr.new/@flint.fyi/browser@b092a80 -D

@flint.fyi/cli

pnpm add https://pkg.pr.new/@flint.fyi/cli@b092a80 -D

@flint.fyi/core

pnpm add https://pkg.pr.new/@flint.fyi/core@b092a80 -D

@flint.fyi/css

pnpm add https://pkg.pr.new/@flint.fyi/css@b092a80 -D

@flint.fyi/css-language

pnpm add https://pkg.pr.new/@flint.fyi/css-language@b092a80 -D

flint

pnpm add https://pkg.pr.new/flint@b092a80 -D

@flint.fyi/json

pnpm add https://pkg.pr.new/@flint.fyi/json@b092a80 -D

@flint.fyi/json-language

pnpm add https://pkg.pr.new/@flint.fyi/json-language@b092a80 -D

@flint.fyi/jsx

pnpm add https://pkg.pr.new/@flint.fyi/jsx@b092a80 -D

@flint.fyi/markdown-language

pnpm add https://pkg.pr.new/@flint.fyi/markdown-language@b092a80 -D

@flint.fyi/md

pnpm add https://pkg.pr.new/@flint.fyi/md@b092a80 -D

@flint.fyi/next

pnpm add https://pkg.pr.new/@flint.fyi/next@b092a80 -D

@flint.fyi/node

pnpm add https://pkg.pr.new/@flint.fyi/node@b092a80 -D

@flint.fyi/nuxt

pnpm add https://pkg.pr.new/@flint.fyi/nuxt@b092a80 -D

@flint.fyi/package-json

pnpm add https://pkg.pr.new/@flint.fyi/package-json@b092a80 -D

@flint.fyi/performance

pnpm add https://pkg.pr.new/@flint.fyi/performance@b092a80 -D

@flint.fyi/plugin-flint

pnpm add https://pkg.pr.new/@flint.fyi/plugin-flint@b092a80 -D

@flint.fyi/react

pnpm add https://pkg.pr.new/@flint.fyi/react@b092a80 -D

@flint.fyi/rule-data

pnpm add https://pkg.pr.new/@flint.fyi/rule-data@b092a80 -D

@flint.fyi/rule-tester

pnpm add https://pkg.pr.new/@flint.fyi/rule-tester@b092a80 -D

@flint.fyi/solid

pnpm add https://pkg.pr.new/@flint.fyi/solid@b092a80 -D

@flint.fyi/spelling

pnpm add https://pkg.pr.new/@flint.fyi/spelling@b092a80 -D

@flint.fyi/svelte

pnpm add https://pkg.pr.new/@flint.fyi/svelte@b092a80 -D

@flint.fyi/svelte-language

pnpm add https://pkg.pr.new/@flint.fyi/svelte-language@b092a80 -D

@flint.fyi/text-language

pnpm add https://pkg.pr.new/@flint.fyi/text-language@b092a80 -D

@flint.fyi/ts

pnpm add https://pkg.pr.new/@flint.fyi/ts@b092a80 -D

@flint.fyi/ts-patch

pnpm add https://pkg.pr.new/@flint.fyi/ts-patch@b092a80 -D

@flint.fyi/typescript-language

pnpm add https://pkg.pr.new/@flint.fyi/typescript-language@b092a80 -D

@flint.fyi/utils

pnpm add https://pkg.pr.new/@flint.fyi/utils@b092a80 -D

@flint.fyi/vitest

pnpm add https://pkg.pr.new/@flint.fyi/vitest@b092a80 -D

@flint.fyi/volar-language

pnpm add https://pkg.pr.new/@flint.fyi/volar-language@b092a80 -D

@flint.fyi/vue

pnpm add https://pkg.pr.new/@flint.fyi/vue@b092a80 -D

@flint.fyi/vue-language

pnpm add https://pkg.pr.new/@flint.fyi/vue-language@b092a80 -D

@flint.fyi/yaml

pnpm add https://pkg.pr.new/@flint.fyi/yaml@b092a80 -D

@flint.fyi/yaml-language

pnpm add https://pkg.pr.new/@flint.fyi/yaml-language@b092a80 -D

commit: b092a80

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[lishaduck]

Good catch!

[michaelfaith]

Just a minor gripe from my side