libeventlog: cap eventlogger kvs txn ops#7291
Merged
mergify[bot] merged 2 commits intoflux-framework:masterfrom Jan 20, 2026
Merged
libeventlog: cap eventlogger kvs txn ops#7291mergify[bot] merged 2 commits intoflux-framework:masterfrom
mergify[bot] merged 2 commits intoflux-framework:masterfrom
Conversation
Problem: In the near future, the code used in a eventlogger timer callback may need to be called directly. Refactor eventlogger to have a separate async_commit() function that can be called. timer_cb() will now simply call async_commit().
Problem: The number of operations in a kvs txn generated by the eventlogger has no cap. In the future when the KVS may have a transaction operations cap, this could cause problems. If the number of operations in a eventlogger batch exceeds a cap, initiate the transaction immediately, even if a timer has not been reached. For the time being, set the cap to a hard coded value. This may become configurable in the future. Fixes flux-framework#6910
chu11
force-pushed
the
issue6910_eventlogger_cap_ops_count
branch
from
eb4283a to
b588fd2
Compare
Contributor
Merge Queue Status✅ The pull request has been merged at b588fd2 This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7291 +/- ##
==========================================
+ Coverage 83.65% 83.67% +0.01%
==========================================
Files 559 559
Lines 93267 93270 +3
==========================================
+ Hits 78022 78040 +18
+ Misses 15245 15230 -15
🚀 New features to boost your workflow:
|
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The number of operations in a kvs txn generated by the eventlogger has no cap. In the future when the KVS may have a transaction operations cap, this could cause problems (see #6581).
If the number of operations in a eventlogger batch exceeds a cap, initiate the transaction immediately, even if a timer has not been reached.
For the time being, set the cap to a hard coded value. This may become configurable in the future.
This is built upon #7271