fix: return error immediately on failed reconciliation status#5692
Open
Aman-Cool wants to merge 1 commit intofluxcd:mainfrom
Open
fix: return error immediately on failed reconciliation status#5692Aman-Cool wants to merge 1 commit intofluxcd:mainfrom
Aman-Cool wants to merge 1 commit intofluxcd:mainfrom
Conversation
Contributor
Author
|
@matheuscscp @stefanprodan ,This makes |
matheuscscp
reviewed
Jan 25, 2026
Member
|
Please squash |
Co-authored-by: Matheus Pimenta <matheuscscp@gmail.com> Signed-off-by: Aman-Cool <aman017102007@gmail.com>
Aman-Cool
force-pushed
the
fix/reconcile-fail-fast-v2
branch
from
bd3f10b to
0a29617
Compare
Contributor
Author
|
@matheuscscp , Squashed into a single commit. All checks are green. |
Contributor
Author
|
@stefanprodan ,Please see it when you have time, happy to help if it needs any updates. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flux reconcile does not fail fast on Failed status
flux reconciledoes not fail fast when a resource is already inFailedstatus.The polling condition treats
FailedStatusthe same asInProgressStatus, so the command waits until the full timeout (default 5 minutes) before reporting an error.This causes unnecessary delays and poor UX. The fix is to return an error for terminal failure states, matching the behavior of
isObjectReady().