fix(remote): detect role-gate errors via pre-walk before match#11
Merged
Conversation
….4 for lasagna-remote 0.1.5
skydread1
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[0.1.5] - 2026-04-24
Fixed
:forbidden(e.g. 403) instead of:match-failure(422). Example:{:member {:posts/history {{:post/id 1} ?v}}}against{:member {:error {:type :forbidden}}}— the matcher would previously descend past the error into nil and fail with "expected map, got nil" at the deepest level, masking the auth denialChanged
execute-readnow runs three steps: walk rawdataalong pattern var-paths to catch role-gate errors, trim the pattern at those paths, match the trimmed pattern, then walk the matcher's:valover the trimmed pattern's var-bindings for errors inside materialized data. Scoping the:valwalk to trimmed bindings prevents re-reporting step-1 errors that map passthrough leaks into:val. Mergesdata-errsandval-errsfor classification{:error ...}must live in plain data. Errors returned fromILookup.valAtremain invisible to detection and will still surface as:match-failurewhen the pattern descends past themAdded
trim-pattern(private fn) — removes pattern branches at detected error paths, returns nil when all branches are trimmeddetect-read-errors(private fn) — walks rawdataalong var-paths through plain maps only