[V2] Pass run context to subaction + return in GetRunDetails#7094
Open
machichima wants to merge 3 commits intoflyteorg:v2from
Open
[V2] Pass run context to subaction + return in GetRunDetails#7094machichima wants to merge 3 commits intoflyteorg:v2from
machichima wants to merge 3 commits intoflyteorg:v2from
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
popojk
reviewed
Mar 27, 2026
| if taskAction == nil || parentTaskAction == nil { | ||
| return | ||
| } | ||
| taskAction.Spec.EnvVars = cloneStringMap(parentTaskAction.Spec.EnvVars) |
Contributor
There was a problem hiding this comment.
Should we append parent action's ENVVAR into child action's ENVVAR instead of overwrite? Child action probably has it's own ENVVAR
Member
Author
There was a problem hiding this comment.
In the current implementation, TaskAction.Spec.EnvVars is treated as run-scoped context projected from RunSpec, not per-subaction overrides.
In flyte-sdk, when enqueue a subaction, we do not pass any RunSpec that can override parent action's context setting
popojk
reviewed
Mar 27, 2026
|
|
||
| if len(action.RunSpec) > 0 { | ||
| spec := &task.RunSpec{} | ||
| if err := proto.Unmarshal(action.RunSpec, spec); err == nil { |
Contributor
There was a problem hiding this comment.
Curious why do we not handling the unmarshal error? Don't we need to log it or return it?
Member
Author
There was a problem hiding this comment.
Yes, I think we should log here. Added in 75290ff
Signed-off-by: machichima <nary12321@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
GetRunDetailsWhat changes were proposed in this pull request?
GetRunDetailsAPIHow was this patch tested?
Run sandbox and ensure 1) run context appears in subactions; 2) We can see env var in the re-run page
subaction TaskAction CR:
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main