fix: allow partial releases when some platform builds fail#34
Merged
Conversation
- Release job now runs even if some builds fail (partial release) - Individual gem push failures don't block other gems - Use 'always() && !cancelled() && needs.build.result != skipped' This ensures GitHub releases are created even when not all platforms build successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The v0.5.1 and v0.5.2 releases were not created because:
aarch64-linux-muslbuild failedWhen any build in the matrix fails, the entire
buildjob is marked as failed, which causes thereleasejob to be skipped (since it hasneeds: buildwithoutif: always()).Fix
Added condition to release job:
This allows the release to proceed with successfully built gems even when some platforms fail.
Testing
After merging, manually trigger a release with
version_bump: skipto create the missing v0.5.2 release.