fix(check-api): treat fonts with empty fvar as static#669
Open
felipesanches wants to merge 1 commit intofonttools:mainfrom
Open
fix(check-api): treat fonts with empty fvar as static#669felipesanches wants to merge 1 commit intofonttools:mainfrom
felipesanches wants to merge 1 commit intofonttools:mainfrom
Conversation
Fonts with an empty fvar table (no axes) are an experimental technique for Office kerning compatibility. Previously, is_variable_font() would return true for these fonts because it only checked for the presence of the fvar table. Now it also checks that the fvar has at least one axis. This fixes false FAILs in the fsselection and mac_style checks. Closes fonttools#574 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_variable_font()to returnfalsefor fonts with an empty fvar table (no axes)fsselectionandmac_stylechecksCloses #574
Test plan
cargo test --workspacepasses (107 tests, 0 failures)cargo clippy --all -- -D warningscleancargo fmt --all -- --checkclean🤖 Generated with Claude Code