Update Forge GNOME extension fork to main#518
Closed
Cartoone9 wants to merge 1 commit intoforge-ext:mainfrom
Closed
Update Forge GNOME extension fork to main#518Cartoone9 wants to merge 1 commit intoforge-ext:mainfrom
Cartoone9 wants to merge 1 commit intoforge-ext:mainfrom
Conversation
Refactor showWindowBorders() into showWindowBordersFor(metaWindow) so borders can be drawn for any window, not just the focused one. Then updateBorderLayout() iterates over every tracked node-window on the active workspace and renders a border for each non-minimized window, tagging unfocused ones with the `window-unfocused` style class so themes can distinguish them from the focused border. Also fix a latent bug in the split-border guard where `!maximized` was checking truthiness of the arrow function (always true) instead of invoking it as `!maximized()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor showWindowBorders() into showWindowBordersFor(metaWindow) so borders can be drawn for any window, not just the focused one. Then updateBorderLayout() iterates over every tracked node-window on the active workspace and renders a border for each non-minimized window, tagging unfocused ones with the
window-unfocusedstyle class so themes can distinguish them from the focused border.Also fix a latent bug in the split-border guard where
!maximizedwas checking truthiness of the arrow function (always true) instead of invoking it as!maximized().