fix: Min Value for Sample per Second , Bins , Number Channels#598
Open
refactor-droidyy wants to merge 1 commit intofossasia:developmentfrom
Open
fix: Min Value for Sample per Second , Bins , Number Channels#598refactor-droidyy wants to merge 1 commit intofossasia:developmentfrom
refactor-droidyy wants to merge 1 commit intofossasia:developmentfrom
Conversation
dheerajkotwani
suggested changes
Jan 24, 2020
|
|
||
| <EditTextPreference | ||
| android:defaultValue="3" | ||
| android:digits="0123456789" |
Member
There was a problem hiding this comment.
This will prevent user from entering '0' from the input. What if user wants to enter '10'?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]