Fixes #646 : App crash fixed on Share click#684
Open
NikunjGarg2000 wants to merge 1 commit intofossasia:developmentfrom
Open
Fixes #646 : App crash fixed on Share click#684NikunjGarg2000 wants to merge 1 commit intofossasia:developmentfrom
NikunjGarg2000 wants to merge 1 commit intofossasia:developmentfrom
Conversation
Author
|
@jddeep , @adityastic, @CloudyPadmal please review this one. |
Author
|
Also #650 is the same issue. |
|
hello sir, I saw this issue is open, can i work on it? If this issue is already assigned, sorry about bothering you, im new to contributing on fossiasia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #646
Changes: [Add here what changes were made in this issue and if possible provide links.]
It was crashing because of NULL pointer exception therefore I added a check if that is NULL and it now works smoothly
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]app-debug.zip